Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added autoplay next related video feature #428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added autoplay next related video feature #428

wants to merge 1 commit into from

Conversation

PraveenRaj1833
Copy link

@PraveenRaj1833 PraveenRaj1833 commented Oct 23, 2023 •
edited
Loading

Motivation and Context

  • This change includes the autoplaying of next related video. Also few changes in css as mentioned in previous PR
    discussions.
  • Closes this issue

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Added autoplay feature, I am fetching the related videos based on the tags of the present video.
  • A button to toggle(on/off) autoplay.
  • Tested in both safari and chrome
Screenshot 2023-10-23 at 6 33 15 PM

Final checklist:

Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING guidelines.
  • All tests passed.

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zen-audio-player-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 1:59pm

@shakeelmohamed
Copy link
Member

@PraveenRaj1833 Exciting to see this PR come through, thank you! It’s on my list to review

@PraveenRaj1833
Copy link
Author

Thank you @shakeelmohamed, It was quite a good learning for me. Waiting for your suggestions on this.
Also as I was working on this today for long time, I think the 10,000 units free quota for today might be exceeded. It will renew tomorrow Pacific time. Sorry for over-usage 😅.

@PraveenRaj1833
Copy link
Author

Hi @shakeelmohamed, did you get a chance to review the code?

@shakeelmohamed
Copy link
Member

shakeelmohamed commented Dec 24, 2023 •
edited
Loading

@PraveenRaj1833, I’m just getting to this now.

Can you provide a quick outline of the different user flows through this feature?
I’ll need an hour or so to play with this either way since it’s a significant code change.

Related to the user flows, are you interested in writing automated tests for this feature?

@shakeelmohamed
Copy link
Member

hi @PraveenRaj1833, are you interested in writing some tests for this awesome feature?
I haven’t reviewed the code yet, would be great if we can get some automated testing in place to ensure nothing breaks down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs manual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autoplay Feature from Youtube
2 participants
@PraveenRaj1833 @shakeelmohamed